netdev - Re: [PATCH net v3] ipv6: sr: validate HMAC algorithm ID in seg6_hmac_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJ4FUauS-3Ymarop@shredder>
Date: Thu, 14 Aug 2025 18:48:33 +0300
From: Ido Schimmel <idosch@...sch.org>
To: heminhong <heminhong@...inos.cn>
Cc: dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org,
	kuniyu@...gle.com, netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net v3] ipv6: sr: validate HMAC algorithm ID in
 seg6_hmac_info_add

On Thu, Aug 14, 2025 at 02:33:02PM +0800, heminhong wrote:
> From: Minhong He <heminhong@...inos.cn>
> 
> The seg6_genl_sethmac() directly uses the algorithm ID provided by the
> userspace without verifying whether it is an HMAC algorithm supported
> by the system.
> If an unsupported HMAC algorithm ID is configured, packets using SRv6 HMAC
> will be dropped during encapsulation or decapsulation.
> To keep the HMAC algorithm logic in seg6_hmac.c and perform the check
> in seg6_hmac_info_add().

The "To" doesn't seem necessary in the last sentence?

> 
> Fixes: 4f4853dc1c9c ("ipv6: sr: implement API to control SR HMAC structure")
> Signed-off-by: Minhong He <heminhong@...inos.cn>

Reviewed-by: Ido Schimmel <idosch@...dia.com>