netdev - Re: [PATCH net-next v6 10/19] psp: track generations of device key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504a5c1c-83eb-4940-bd2b-66f8c3f26c03@redhat.com>
Date: Thu, 14 Aug 2025 18:47:33 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Daniel Zahka <daniel.zahka@...il.com>,
 Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 Andrew Lunn <andrew+netdev@...n.ch>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, Boris Pismenny <borisp@...dia.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Willem de Bruijn
 <willemb@...gle.com>, David Ahern <dsahern@...nel.org>,
 Neal Cardwell <ncardwell@...gle.com>, Patrisious Haddad
 <phaddad@...dia.com>, Raed Salem <raeds@...dia.com>,
 Jianbo Liu <jianbol@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
 Rahul Rameshbabu <rrameshbabu@...dia.com>,
 Stanislav Fomichev <sdf@...ichev.me>,
 Toke Høiland-Jørgensen <toke@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Kiran Kella <kiran.kella@...adcom.com>,
 Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 10/19] psp: track generations of device key

On 8/14/25 5:53 PM, Daniel Zahka wrote:
> On 8/14/25 10:07 AM, Paolo Abeni wrote:
>> On 8/12/25 2:29 AM, Daniel Zahka wrote:
>>> +void psp_assocs_key_rotated(struct psp_dev *psd)
>>> +{
>>> +	struct psp_assoc *pas, *next;
>>> +
>>> +	/* Mark the stale associations as invalid, they will no longer
>>> +	 * be able to Rx any traffic.
>>> +	 */
>>> +	list_for_each_entry_safe(pas, next, &psd->prev_assocs, assocs_list)
>>> +		pas->generation |= ~PSP_GEN_VALID_MASK;
>>> +	list_splice_init(&psd->prev_assocs, &psd->stale_assocs);
>>> +	list_splice_init(&psd->active_assocs, &psd->prev_assocs);
>> AFAICS the prev_assocs size is unbounded, and keep increasing at each
>> key rotation, am I correct?
> 
> psp_assoc objects are added to the active list during psp_assoc_create() 
> in the rx-assoc netlink op, and then removed from whichever of the three 
> lists it happens to be on during psp_assoc_free(), which is called when 
> its refcount goes to 0. So basically, a key rotation will shift the 
> psp_assoc's associated with the device around in terms of bookkeeping, 
> but the total length of these three lists combined is determined only by 
> the number of sockets in the system that have entered the rx-assoc 
> state, and have yet to be closed. For now, there can only ever be one 
> assoc per socket.

I see, looks good.

/P