netdev - Re: [PATCH v2] net: usb: asix_devices: add phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJ2GrsiISQqbkZsF@pengutronix.de>
Date: Thu, 14 Aug 2025 08:48:14 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Xu Yang <xu.yang_2@....com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, max.schulze@...ine.de,
	khalasa@...p.pl, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH v2] net: usb: asix_devices: add phy_mask for ax88772 mdio
 bus

On Mon, Aug 11, 2025 at 05:29:31PM +0800, Xu Yang wrote:
> Without setting phy_mask for ax88772 mdio bus, current driver may create
> at most 32 mdio phy devices with phy address range from 0x00 ~ 0x1f.
> DLink DUB-E100 H/W Ver B1 is such a device. However, only one main phy
> device will bind to net phy driver. This is creating issue during system
> suspend/resume since phy_polling_mode() in phy_state_machine() will
> directly deference member of phydev->drv for non-main phy devices. Then
> NULL pointer dereference issue will occur. Due to only external phy or
> internal phy is necessary, add phy_mask for ax88772 mdio bus to workarnoud
> the issue.
> 
> Closes: https://lore.kernel.org/netdev/20250806082931.3289134-1-xu.yang_2@nxp.com
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Xu Yang <xu.yang_2@....com>

Tested-by: Oleksij Rempel <o.rempel@...gutronix.de>
Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you! 
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |