netdev - Re: [PATCH net] bnxt_en: Fix lockdep warning during rmmod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815101258.37cb17b1@kernel.org>
Date: Fri, 15 Aug 2025 10:12:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, pavan.chebbi@...adcom.com,
 andrew.gospodarek@...adcom.com, sdf@...ichev.me
Subject: Re: [PATCH net] bnxt_en: Fix lockdep warning during rmmod

On Fri, 15 Aug 2025 10:08:23 -0700 Michael Chan wrote:
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 2800a90fba1f..a208c2a73cd6 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -5332,7 +5332,8 @@ static void bnxt_free_ntp_fltrs(struct bnxt *bp, bool all)
>  {
>  	int i;
>  
> -	netdev_assert_locked(bp->dev);
> +	if (bp->dev->reg_state == NETREG_REGISTERED)
> +		netdev_assert_locked(bp->dev);
>  
>  	/* Under netdev instance lock and all our NAPIs have been disabled.
>  	 * It's safe to delete the hash table.

netdev_assert_locked_or_invisible()
-- 
pw-bot: cr