netdev - Re: [PATCH net-next v1] mlxbf_gige: report unknown speed and duplex when link is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815121102.0653f13f@kernel.org>
Date: Fri, 15 Aug 2025 12:11:02 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Chris Babroski <cbabroski@...dia.com>
Cc: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <davthompson@...dia.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v1] mlxbf_gige: report unknown speed and duplex
 when link is down

On Wed, 13 Aug 2025 12:33:46 -0400 Chris Babroski wrote:
> The "Speed" and "Duplex" fields displayed by ethtool should report
> "Unknown" when the link is down. Currently, the driver always reports
> the initially configured link speed and duplex, regardless of the actual
> link state.
> 
> Implement a get_link_ksettings() callback to update the values reported
> to ethtool based on the link state. When the link is down, the driver
> now reports unknown speed and duplex as expected.

If that's the correct thing to do why is
phy_ethtool_get_link_ksettings() not doing it?

Please explain what makes mlxbf special, and make sure to CC PHY
maintainers on v2.
-- 
pw-bot: cr