netdev - Re: [PATCH net v5 1/2] net/sched: Fix backlog accounting in qdisc_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175522140825.510661.16232160646168789853.git-patchwork-notify@kernel.org>
Date: Fri, 15 Aug 2025 01:30:08 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: William Liu <will@...lsroot.io>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
 pabeni@...hat.com, kuba@...nel.org, jiri@...nulli.us, davem@...emloft.net,
 edumazet@...gle.com, horms@...nel.org, savy@...t3mfailure.io,
 victor@...atatu.com
Subject: Re: [PATCH net v5 1/2] net/sched: Fix backlog accounting in
 qdisc_dequeue_internal

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 12 Aug 2025 23:57:57 +0000 you wrote:
> This issue applies for the following qdiscs: hhf, fq, fq_codel, and
> fq_pie, and occurs in their change handlers when adjusting to the new
> limit. The problem is the following in the values passed to the
> subsequent qdisc_tree_reduce_backlog call given a tbf parent:
> 
>    When the tbf parent runs out of tokens, skbs of these qdiscs will
>    be placed in gso_skb. Their peek handlers are qdisc_peek_dequeued,
>    which accounts for both qlen and backlog. However, in the case of
>    qdisc_dequeue_internal, ONLY qlen is accounted for when pulling
>    from gso_skb. This means that these qdiscs are missing a
>    qdisc_qstats_backlog_dec when dropping packets to satisfy the
>    new limit in their change handlers.
> 
> [...]

Here is the summary with links:
  - [net,v5,1/2] net/sched: Fix backlog accounting in qdisc_dequeue_internal
    https://git.kernel.org/netdev/net/c/52bf272636bd
  - [net,v5,2/2] selftests/tc-testing: Check backlog stats in gso_skb case
    https://git.kernel.org/netdev/net/c/8c06cbdcbaea

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html