netdev - Re: [PATCH net-next v11 08/16] net: phy: Introduce generic SFP handling for PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508151058.jqJsn9VB-lkp@intel.com>
Date: Fri, 15 Aug 2025 11:25:55 +0800
From: kernel test robot <lkp@...el.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Herve Codina <herve.codina@...tlin.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Marek Behún <kabel@...nel.org>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Nicolò Veronese <nicveronese@...il.com>,
	Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
	Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>,
	Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH net-next v11 08/16] net: phy: Introduce generic SFP
 handling for PHY drivers

Hi Maxime,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/dt-bindings-net-Introduce-the-ethernet-connector-description/20250814-221559
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250814135832.174911-9-maxime.chevallier%40bootlin.com
patch subject: [PATCH net-next v11 08/16] net: phy: Introduce generic SFP handling for PHY drivers
config: i386-randconfig-013-20250815 (https://download.01.org/0day-ci/archive/20250815/202508151058.jqJsn9VB-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250815/202508151058.jqJsn9VB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508151058.jqJsn9VB-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phy_device.c:1625:47: warning: variable 'iface' is uninitialized when used here [-Wuninitialized]
    1625 |                 return port->ops->configure_mii(port, true, iface);
         |                                                             ^~~~~
   drivers/net/phy/phy_device.c:1597:2: note: variable 'iface' is declared here
    1597 |         phy_interface_t iface;
         |         ^
   1 warning generated.


vim +/iface +1625 drivers/net/phy/phy_device.c

  1589	
  1590	static int phy_sfp_module_insert(void *upstream, const struct sfp_eeprom_id *id)
  1591	{
  1592		struct phy_device *phydev = upstream;
  1593		struct phy_port *port;
  1594	
  1595		__ETHTOOL_DECLARE_LINK_MODE_MASK(sfp_support);
  1596		DECLARE_PHY_INTERFACE_MASK(interfaces);
  1597		phy_interface_t iface;
  1598	
  1599		linkmode_zero(sfp_support);
  1600	
  1601		port = phy_get_sfp_port(phydev);
  1602		if (!port)
  1603			return -EINVAL;
  1604	
  1605		sfp_parse_support(phydev->sfp_bus, id, sfp_support, interfaces);
  1606	
  1607		if (phydev->n_ports == 1)
  1608			phydev->port = sfp_parse_port(phydev->sfp_bus, id, sfp_support);
  1609	
  1610		linkmode_and(sfp_support, port->supported, sfp_support);
  1611		linkmode_and(interfaces, interfaces, port->interfaces);
  1612	
  1613		if (linkmode_empty(sfp_support)) {
  1614			dev_err(&phydev->mdio.dev, "incompatible SFP module inserted, no common linkmode\n");
  1615			return -EINVAL;
  1616		}
  1617	
  1618		/* Check that this interface is supported */
  1619		if (!test_bit(iface, port->interfaces)) {
  1620			dev_err(&phydev->mdio.dev, "PHY %s does not support the SFP module's requested MII interfaces\n", phydev_name(phydev));
  1621			return -EINVAL;
  1622		}
  1623	
  1624		if (port->ops && port->ops->configure_mii)
> 1625			return port->ops->configure_mii(port, true, iface);
  1626	
  1627		return 0;
  1628	}
  1629	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki