netdev - Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250816155510.03a99223@hermes.local>
Date: Sat, 16 Aug 2025 15:55:10 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
Cc: dsahern@...il.com, netdev@...r.kernel.org, haiyangz@...rosoft.com,
 shradhagupta@...ux.microsoft.com, ssengar@...rosoft.com,
 dipayanroy@...rosoft.com, ernis@...rosoft.com
Subject: Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to
 'ip link' for netdev shaping

On Mon, 11 Aug 2025 00:05:02 -0700
Erni Sri Satya Vennela <ernis@...ux.microsoft.com> wrote:

> Add support for the netshaper Generic Netlink
> family to iproute2. Introduce a new subcommand to `ip link` for
> configuring netshaper parameters directly from userspace.
> 
> This interface allows users to set shaping attributes (such as speed)
> which are passed to the kernel to perform the corresponding netshaper
> operation.
> 
> Example usage:
> $ip link netshaper { set | get | delete } dev DEVNAME \
>                    handle scope SCOPE id ID \
>                    [ speed SPEED ]


The choice of ip link is awkward and doesn't match other options.
I can think of some better other choices:

  1. netshaper could be a property of the device. But the choice of using genetlink
     instead of regular ip netlink attributes makes this hard.
  2. netshaper could be part of devlink. Since it is more targeted at hardware
     device attributes.
  3. netshaper could be a standalone command like bridge, dcb, devlink, rdma, tipc and vdpa.

What ever choice the command line options need to follow similar syntax to other iproute commands.