netdev - Re: [PATCH net-next 5/7] net: stmmac: use core wake IRQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00b45ff8-b5fa-4453-a389-a7252aa1da6d@lunn.ch>
Date: Sun, 17 Aug 2025 18:03:50 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 5/7] net: stmmac: use core wake IRQ support

On Fri, Aug 15, 2025 at 12:32:10PM +0100, Russell King (Oracle) wrote:
> The PM core provides management of wake IRQs along side setting the
> device wake enable state. In order to use this, we need to register
> the interrupt used to wakeup the system using devm_pm_set_wake_irq()
> or dev_pm_set_wake_irq(). The core will then enable or disable IRQ
> wake state on this interrupt as appropriate, depending on the
> device_set_wakeup_enable() state. device_set_wakeup_enable() does not
> care about having balanced enable/disable calls.
> 
> Make use of this functionality, rather than explicitly managing the
> IRQ enable state in the set_wol() ethtool op. This removes the IRQ
> wake state management from stmmac.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew