netdev - Re: [PATCH 5/6] can: esd_usb: Rework display of error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <781debe349bbb7b757038ddbef9fbea5b5efae89.camel@esd.eu>
Date: Mon, 18 Aug 2025 12:21:23 +0000
From: Stefan Mätje <stefan.maetje@....eu>
To: "mkl@...gutronix.de" <mkl@...gutronix.de>
CC: "socketcan@...tkopp.net" <socketcan@...tkopp.net>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, "mailho@...nel.org"
	<mailho@...nel.org>, socketcan <socketcan@....eu>, Frank Jungclaus
	<frank.jungclaus@....eu>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"horms@...nel.org" <horms@...nel.org>, "olivier@...rie.be"
	<olivier@...rie.be>
Subject: Re: [PATCH 5/6] can: esd_usb: Rework display of error messages

Am Donnerstag, dem 14.08.2025 um 14:45 +0200 schrieb Marc Kleine-Budde:
> On 13.08.2025 10:12:03, Marc Kleine-Budde wrote:
> > On 11.08.2025 23:06:10, Stefan Mätje wrote:
> > > - esd_usb_open(): Get rid of duplicate "couldn't start device: %d\n"
> > >   message already printed from esd_usb_start().
> > > - Added the printout of error codes together with the error messages
> > >   in esd_usb_close() and some in esd_usb_probe(). The additional error
> > >   codes should lead to a better understanding what is really going
> > >   wrong.
> > > - Fix duplicate printout of network device name when network device
> > >   is registered. Add an unregister message for the network device
> > >   as counterpart to the register message.
> > 
> > If you want to print errors, please use '"%pE", ERR_PTR(err)', that will
> > decode the error code into human readable form.
> 
> Sorry, I meant to say "%pe".

Thanks for that hint. I will rework all occurrences of '"...: %d\n", err'
with a version based on "ERR_PTR(err)" and send a V2.

Stefan