netdev - Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8a5c557-f76c-4bbd-a181-d35736ef4cbb@microchip.com>
Date: Mon, 18 Aug 2025 04:44:52 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <kuba@...nel.org>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration for
 Rev.B0/B1 as per AN1760

Hi Kakub,

Thank you for reviewing the patches.

On 16/08/25 7:10 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, 13 Aug 2025 16:03:55 +0530 Parthiban Veerasooran wrote:
>> +#define LAN865X_REG_FIXUP            0x00010077
>> +#define LAN865X_FIXUP_VALUE          0x0028
> 
> Looks like the application note explains what this register is and what
> is the meaning of the bits in it. Please break this up and name
> properly. "FIXUP_REGISTER" and "FIXUP_VALUE" is about as useful
> as naming it "REGSITER_AT_10077" and "VALUE_28" :/
Yes, sure. I will update the correct details in the next version.

Since this falls under the initial settings, I initially kept this 
configuration as a "fixup," similar to what we did in the PHY driver. In 
that case, the PHY initial settings didn’t have valid register names or 
details, so the "fixup" approach was appropriate.

However, in this case, we do have the register names and details 
available in the configuration application note. So, I will update the 
configuration accordingly.

Best regards,
Parthiban V
> --
> pw-bot: cr