netdev - Re: [PATCH net-next] selftests: drv-net: tso: increase the retransmit threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250818085246.754ea32d@kernel.org>
Date: Mon, 18 Aug 2025 08:52:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 shuah@...nel.org, willemb@...gle.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: tso: increase the
 retransmit threshold

On Fri, 15 Aug 2025 21:41:37 -0400 Daniel Zahka wrote:
> On 8/15/25 6:41 PM, Jakub Kicinski wrote:
> > We see quite a few flakes during the TSO test against virtualized
> > devices in NIPA. There's often 10-30 retransmissions during the
> > test. Sometimes as many as 100. Set the retransmission threshold
> > at 1/4th of the wire frame target.  
> 
> Did this issue preexist these commits:
> b25b44cd178c ("selftests: drv-net: tso: fix non-tunneled tso6 test case 
> name")
> 2cfbcc5d8af9 ("selftests: drv-net: tso: fix vxlan tunnel flags to get 
> correct gso_type")
> 266b835e5e84 ("selftests: drv-net: tso: enable test cases based on 
> hw_features")
> 
> or is this a possible regression?

I think it existed before, but it was much harder to spot flakes prior
to those fixes because the whole test was failing. Here's an example of
110 retransmits 3 weeks before those fixes:
https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu/results/192642/4-tso-py/stdout