Message-ID: <8ad6bb71-9ce5-414a-bbf6-b9893b88cb4f@ti.com>
Date: Mon, 18 Aug 2025 21:29:16 +0530
From: "Anwar, Md Danish" <a0501179@...com>
To: Parvathi Pudi <parvathi@...thit.com>, <danishanwar@...com>,
        <rogerq@...nel.org>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <ssantosh@...nel.org>, <richardcochran@...il.com>, <m-malladi@...com>,
        <s.hauer@...gutronix.de>, <afd@...com>, <jacob.e.keller@...el.com>,
        <horms@...nel.org>, <johan@...nel.org>, <m-karicheri2@...com>,
        <s-anna@...com>, <glaroque@...libre.com>, <saikrishnag@...vell.com>,
        <kory.maincent@...tlin.com>, <diogo.ivo@...mens.com>,
        <javier.carrasco.cruz@...il.com>, <basharath@...thit.com>
CC: <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <vadim.fedorenko@...ux.dev>, <alok.a.tiwari@...cle.com>,
        <bastien.curutchet@...tlin.com>, <pratheesh@...com>, <prajith@...com>,
        <vigneshr@...com>, <praneeth@...com>, <srk@...com>, <rogerq@...com>,
        <krishna@...thit.com>, <pmohan@...thit.com>, <mohan@...thit.com>
Subject: Re: [PATCH net-next v13 0/5] PRU-ICSSM Ethernet Driver

Hi Parvathi

On 8/12/2025 4:35 PM, Parvathi Pudi wrote:
> Hi,
> 
> The Programmable Real-Time Unit Industrial Communication Sub-system (PRU-ICSS)
> is available on the TI SOCs in two flavors: Gigabit ICSS (ICSSG) and the older
> Megabit ICSS (ICSSM).
> 
> Support for ICSSG Dual-EMAC mode has already been mainlined [1] and the
> fundamental components/drivers such as PRUSS driver, Remoteproc driver,
> PRU-ICSS INTC, and PRU-ICSS IEP drivers are already available in the mainline
> Linux kernel. The current set of patch series builds on top of these components
> and introduces changes to support the Dual-EMAC using ICSSM on the TI AM57xx,
> AM437x and AM335x devices.
> 
> AM335x, AM437x and AM57xx devices may have either one or two PRU-ICSS instances
> with two 32-bit RISC PRU cores. Each PRU core has (a) dedicated Ethernet interface
> (MII, MDIO), timers, capture modules, and serial communication interfaces, and
> (b) dedicated data and instruction RAM as well as shared RAM for inter PRU
> communication within the PRU-ICSS.
> 
> These patches add support for basic RX and TX  functionality over PRU Ethernet
> ports in Dual-EMAC mode.
> 
> Further, note that these are the initial set of patches for a single instance of
> PRU-ICSS Ethernet.  Additional features such as Ethtool support, VLAN Filtering,
> Multicast Filtering, Promiscuous mode, Storm prevention, Interrupt coalescing,
> Linux PTP (ptp4l) Ordinary clock and Switch mode support for AM335x, AM437x
> and AM57x along with support for a second instance of  PRU-ICSS on AM57x
> will be posted subsequently.
> 
> The patches presented in this series have gone through the patch verification
> tools and no warnings or errors are reported. Sample test logs obtained from AM33x,
> AM43x and AM57x verifying the functionality on Linux next kernel are available here:
> 
> [Interface up Testing](https://gist.github.com/ParvathiPudi/e24ae1971258b689c411bf6d8b504576)
> 
> [Ping Testing](https://gist.github.com/ParvathiPudi/6077cc7ab71eb0bc62ef0435ce9a5572)
> 
> [Iperf Testing](https://gist.github.com/ParvathiPudi/54aec8d6aaa1149b68589af9c8511b23)
> 
> [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/
> [2] https://lore.kernel.org/all/20250108125937.10604-1-basharath@couthit.com/
> 
> This is the v13 of the patch series [v1]. This version of the patchset
> addresses the comments made on [v12] of the series.
> 
> Changes from v12 to v13 :
> 
> *) Addressed Alok Tiwari comments on patch 2, 3 and 5 of the series.
> *) Addressed Bastien Curutchet comment on patch 2 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v11 to v12 :
> 
> *) Addressed Jakub Kicinski's comments on patch 2 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v10 to v11 :
> 
> *) Reduced patch series size by removing features such as Ethtool support,
> VLAN filtering, Multicast filtering, Promiscuous mode handling, Storm Prevention,
> Interrupt coalescing, and Linux PTP (ptp4l) ordinary clock support. This was done
> based on Jakub Kicinski's feedback regarding the large patch size (~5kLoC).
> Excluded features will be resubmitted.
> *) Addressed Jakub Kicinski comments on patch 2, and 3 of the series.
> *) Addressed Jakub Kicinski's comment on patch 4 of the series by implementing
> hrtimer based TX resume logic to notify upper layers in case of TX busy.
> *) Rebased the series on latest net-next.
> 
> Changes from v9 to v10 :
> 
> *) Addressed Vadim Fedorenko comments on patch 6 and 11 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v8 to v9 :
> 
> *) Addressed Vadim Fedorenko comments on patch 6 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v7 to v8 :
> 
> *) Addressed Paolo Abeni comments on patch 3 and 4 of the series.
> *) Replaced threaded IRQ logic with NAPI logic based on feedback from Paolo Abeni.
> *) Added Reviewed-by: tag from Rob Herring for patch 1.
> *) Rebased the series on latest net-next.
> 
> Changes from v6 to v7 :
> 
> *) Addressed Rob Herring comments on patch 1 of the series.
> *) Addressed Jakub Kicinski comments on patch 4, 5 and 6 of the series.
> *) Addressed Alok Tiwari comments on Patch 1, 4 and 5 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v5 to v6 :
> 
> *) Addressed Simon Horman comments on patch 2, 7 and 11 of the series.
> *) Addressed Andrew Lunn comments on patch 5 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v4 to v5 :
> 
> *) Addressed Andrew Lunn and Keller, Jacob E comments on patch 5 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v3 to v4 :
> 
> *) Added support for AM33x and AM43x platforms.
> *) Removed SOC patch [2] and its dependencies.
> *) Addressed Jakub Kicinski, MD Danish Anwar and Nishanth Menon comments on cover
>    letter of the series.
> *) Addressed Rob Herring comments on patch 1 of the series.
> *) Addressed Ratheesh Kannoth comments on patch 2 of the series.
> *) Addressed Maxime Chevallier comments on patch 4 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v2 to v3 :
> 
> *) Addressed Conor Dooley comments on patch 1 of the series.
> *) Addressed Simon Horman comments on patch 2, 3, 4, 5 and 6 of the series.
> *) Addressed Joe Damato comments on patch 4 of the series.
> *) Rebased the series on latest net-next.
> 
> Changes from v1 to v2 :
> 
> *) Addressed Andrew Lunn, Rob Herring comments on patch 1 of the series.
> *) Addressed Andrew Lunn comments on patch 2, 3, and 4 of the series.
> *) Addressed Richard Cochran, Jason Xing comments on patch 6 of the series.
> *) Rebased patchset on next-202401xx linux-next.
> 
> [v1] https://lore.kernel.org/all/20250109105600.41297-1-basharath@couthit.com/
> [v2] https://lore.kernel.org/all/20250124122353.1457174-1-basharath@couthit.com/
> [v3] https://lore.kernel.org/all/20250214054702.1073139-1-parvathi@couthit.com/
> [v4] https://lore.kernel.org/all/20250407102528.1048589-1-parvathi@couthit.com/
> [v5] https://lore.kernel.org/all/20250414113458.1913823-1-parvathi@couthit.com/
> [v6] https://lore.kernel.org/all/20250423060707.145166-1-parvathi@couthit.com/
> [v7] https://lore.kernel.org/all/20250503121107.1973888-1-parvathi@couthit.com/
> [v8] https://lore.kernel.org/all/20250610105721.3063503-1-parvathi@couthit.com/
> [v9] https://lore.kernel.org/all/20250623135949.254674-1-parvathi@couthit.com/
> [v10] https://lore.kernel.org/all/20250702140633.1612269-1-parvathi@couthit.com/
> [v11] https://lore.kernel.org/all/20250722132700.2655208-1-parvathi@couthit.com/
> [v12] https://lore.kernel.org/all/20250724072535.3062604-1-parvathi@couthit.com/
> 
> Thanks and Regards,
> Parvathi.
> 
> Parvathi Pudi (2):
>   dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for
>     AM57xx, AM43xx and AM33xx SOCs
>   net: ti: prueth: Adds IEP support for PRUETH on AM33x, AM43x and AM57x
>     SOCs
> 
> Roger Quadros (3):
>   net: ti: prueth: Adds ICSSM Ethernet driver
>   net: ti: prueth: Adds PRUETH HW and SW configuration
>   net: ti: prueth: Adds link detection, RX and TX support.
> 

Can you please use prefix "net: ti: icssm-prueth" instead of net: ti:
prueth" throughout the series?

icssg driver uses prefix "net: ti: icssg-prueth" so this will be similar
to that.

This way grepping in git log for,
- icssm will give you only icssm patches
- icssg will give you only icssg patches
- prueth will give you both icssm and icssg patches

-- 
Thanks and Regards,
Md Danish Anwar

Powered by blists - more mailing lists