netdev - Re: [PATCH] net: usb: asix: avoid to call phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yynqwoltgvequoysbzivrpff3bpr734wtzce4um6ugx6ca4lpm@useknrj6bmwr>
Date: Mon, 18 Aug 2025 14:44:12 +0800
From: Xu Yang <xu.yang_2@....com>
To: Andrew Lunn <andrew@...n.ch>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, max.schulze@...ine.de, khalasa@...p.pl, 
	o.rempel@...gutronix.de, linux-usb@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev, jun.li@....com
Subject: Re: [PATCH] net: usb: asix: avoid to call phylink_stop() a second
 time

On Fri, Aug 15, 2025 at 02:59:12PM +0200, Andrew Lunn wrote:
> > > > Looking at ax88172a.c, lan78xx.c and smsc95xx.c, they don't have
> > > > anything like this. Is asix special, or are all the others broken as
> > > > well?
> > > 
> > > I have limited USB net devices. So I can't test others now.
> > > 

[...]

> > > 
> > > Should I change usbnet common code like below?
> > > 
> > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> > > index c39dfa17813a..44a8d325dfb1 100644
> > > --- a/drivers/net/usb/usbnet.c
> > > +++ b/drivers/net/usb/usbnet.c
> > > @@ -839,7 +839,7 @@ int usbnet_stop (struct net_device *net)
> > >         pm = usb_autopm_get_interface(dev->intf);
> > >         /* allow minidriver to stop correctly (wireless devices to turn off
> > >          * radio etc) */
> > > -       if (info->stop) {
> > > +       if (info->stop && !dev->suspend_count) {
> > >                 retval = info->stop(dev);
> > >                 if (retval < 0)
> > >                         netif_info(dev, ifdown, dev->net,
> > 
> > Do you mind sharing some suggestions on this? Thanks in advance!
> 
> It does look to be a common problem, so solving it in usbnet would be
> best.

Okay. Thank you!

Thanks,
Xu Yang

> 
> 	Andrew