netdev - [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250818090217.2789521-1-o.rempel@pengutronix.de>
Date: Mon, 18 Aug 2025 11:02:14 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Andrew Lunn <andrew+netdev@...n.ch>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
	kernel@...gutronix.de,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Simon Horman <horms@...nel.org>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Søren Andersen <san@...v.dk>
Subject: [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets

Hi all,

this series reworks how stmmac handles receive checksum offload
(CoE) errors on dwmac4.

At present, when CoE is enabled, the hardware silently discards any
frame that fails checksum validation. These packets never reach the
driver and are not accounted in the generic drop statistics. They are
only visible in the stmmac-specific counters as "payload error" or
"header error" packets, which makes it harder to debug or monitor
network issues.

Following discussion [1], the driver is reworked to propagate checksum
error information up to the stack. With these changes, CoE stays
enabled, but frames that fail hardware validation are no longer dropped
in hardware. Instead, the driver marks them with CHECKSUM_NONE so the
network stack can validate, drop, and properly account them in the
standard drop statistics.

[1] https://lore.kernel.org/all/20250625132117.1b3264e8@kernel.org/

Oleksij Rempel (3):
  net: stmmac: Correctly handle Rx checksum offload errors
  net: stmmac: dwmac4: report Rx checksum errors in status
  net: stmmac: dwmac4: stop hardware from dropping checksum-error
    packets

 drivers/net/ethernet/stmicro/stmmac/dwmac4.h       | 1 +
 drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 8 ++++++--
 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c   | 2 ++
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 3 ++-
 4 files changed, 11 insertions(+), 3 deletions(-)

--
2.39.5