netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] igbvf: remove redundant counter rx_long_byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986EFD5F42D8EF46BE38532E530A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 19 Aug 2025 08:19:03 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Kohei Enju <enjuk@...zon.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"kohei.enju@...il.com" <kohei.enju@...il.com>, Paul Menzel
	<pmenzel@...gen.mpg.de>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] igbvf: remove redundant
 counter rx_long_byte_count from ethtool statistics



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Kohei Enju
> Sent: Monday, August 18, 2025 5:18 PM
> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; kohei.enju@...il.com; Kohei Enju
> <enjuk@...zon.com>; Paul Menzel <pmenzel@...gen.mpg.de>
> Subject: [Intel-wired-lan] [PATCH v2 iwl-next 2/2] igbvf: remove
> redundant counter rx_long_byte_count from ethtool statistics
> 
> rx_long_byte_count shows the value of the GORC (Good Octets Received
> Count) register. However, the register value is already shown as
> rx_bytes and they always show the same value.
> 
> Remove rx_long_byte_count as the Intel ethernet driver e1000e did in
> commit 0a939912cf9c ("e1000e: cleanup redundant statistics counter").
> 
> Tested on Intel Corporation I350 Gigabit Network Connection.
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> Signed-off-by: Kohei Enju <enjuk@...zon.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> ---
>  drivers/net/ethernet/intel/igbvf/ethtool.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c
> b/drivers/net/ethernet/intel/igbvf/ethtool.c
> index c6defc495f13..9c08ebfad804 100644
> --- a/drivers/net/ethernet/intel/igbvf/ethtool.c
> +++ b/drivers/net/ethernet/intel/igbvf/ethtool.c
> @@ -36,7 +36,6 @@ static const struct igbvf_stats
> igbvf_gstrings_stats[] = {
>  	{ "lbtx_bytes", IGBVF_STAT(stats.gotlbc, stats.base_gotlbc) },
>  	{ "tx_restart_queue", IGBVF_STAT(restart_queue, zero_base) },
>  	{ "tx_timeout_count", IGBVF_STAT(tx_timeout_count, zero_base)
> },
> -	{ "rx_long_byte_count", IGBVF_STAT(stats.gorc, stats.base_gorc)
> },
>  	{ "rx_csum_offload_good", IGBVF_STAT(hw_csum_good, zero_base)
> },
>  	{ "rx_csum_offload_errors", IGBVF_STAT(hw_csum_err, zero_base)
> },
>  	{ "rx_header_split", IGBVF_STAT(rx_hdr_split, zero_base) },
> --
> 2.48.1