netdev - Re: [PATCH] ethernet: tlan: Convert to use jiffies macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ffb7fa5-641b-47b7-963c-480c8494c85c@intel.com>
Date: Wed, 20 Aug 2025 11:29:37 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: <zhang.enpei@....com.cn>, <chessman@....org>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethernet: tlan: Convert to use jiffies macro

On 8/19/25 10:16, zhang.enpei@....com.cn wrote:
> From: Zhang Enpei <zhang.enpei@....com.cn>
> 
> Use time_after_eq macro instead of using jiffies directly to handle
> wraparound.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@....com.cn>
> ---
>   drivers/net/ethernet/ti/tlan.c | 4 +---

change looks good, and it seems that there is no more candidates in ti/
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
> index a55b0f951181..78e439834f26 100644
> --- a/drivers/net/ethernet/ti/tlan.c
> +++ b/drivers/net/ethernet/ti/tlan.c
> @@ -1817,7 +1817,6 @@ static void tlan_timer(struct timer_list *t)
>   {
>          struct tlan_priv        *priv = timer_container_of(priv, t, timer);
>          struct net_device       *dev = priv->dev;
> -       u32             elapsed;
>          unsigned long   flags = 0;
> 
>          priv->timer.function = NULL;
> @@ -1844,8 +1843,7 @@ static void tlan_timer(struct timer_list *t)
>          case TLAN_TIMER_ACTIVITY:
>                  spin_lock_irqsave(&priv->lock, flags);
>                  if (priv->timer.function == NULL) {
> -                       elapsed = jiffies - priv->timer_set_at;
> -                       if (elapsed >= TLAN_TIMER_ACT_DELAY) {
> +                       if (time_after_eq(jiffies, priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) {
>                                  tlan_dio_write8(dev->base_addr,
>                                                  TLAN_LED_REG, TLAN_LED_LINK);
>                          } else  {