netdev - Re: [PATCH net v2] net/sched: sch_dualpi2: Run prob update timer in softirq to avoid deadlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175565160625.3748899.17255822579721560435.git-patchwork-notify@kernel.org>
Date: Wed, 20 Aug 2025 01:00:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Victor Nogueira <victor@...atatu.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
 jiri@...nulli.us, netdev@...r.kernel.org, chia-yu.chang@...ia-bell-labs.com,
 koen.de_schepper@...ia-bell-labs.com, olga@...isser.org,
 olivier.tilmans@...ia.com, henrist@...rist.net, research@...briscoe.net,
 ij@...nel.org
Subject: Re: [PATCH net v2] net/sched: sch_dualpi2: Run prob update timer in
 softirq to avoid deadlock

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 15 Aug 2025 10:53:17 -0300 you wrote:
> When a user creates a dualpi2 qdisc it automatically sets a timer. This
> timer will run constantly and update the qdisc's probability field.
> The issue is that the timer acquires the qdisc root lock and runs in
> hardirq. The qdisc root lock is also acquired in dev.c whenever a packet
> arrives for this qdisc. Since the dualpi2 timer callback runs in hardirq,
> it may interrupt the packet processing running in softirq. If that happens
> and it runs on the same CPU, it will acquire the same lock and cause a
> deadlock. The following splat shows up when running a kernel compiled with
> lock debugging:
> 
> [...]

Here is the summary with links:
  - [net,v2] net/sched: sch_dualpi2: Run prob update timer in softirq to avoid deadlock
    https://git.kernel.org/netdev/net/c/f179f5bc158f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html