netdev - Re: [PATCH v5 net-next 09/10] net-memcg: Pass struct sock to mem_cgroup_sk_under_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250819182356.75aa4996@kernel.org>
Date: Tue, 19 Aug 2025 18:23:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Kuniyuki Iwashima <kuniyu@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Neal Cardwell
 <ncardwell@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Willem de Bruijn
 <willemb@...gle.com>, Matthieu Baerts <matttbe@...nel.org>, Mat Martineau
 <martineau@...nel.org>, Johannes Weiner <hannes@...xchg.org>, Michal Hocko
 <mhocko@...nel.org>, Roman Gushchin <roman.gushchin@...ux.dev>, Andrew
 Morton <akpm@...ux-foundation.org>, "Michal Koutný"
 <mkoutny@...e.com>, Tejun Heo <tj@...nel.org>, Simon Horman
 <horms@...nel.org>, Geliang Tang <geliang@...nel.org>, Muchun Song
 <muchun.song@...ux.dev>, Mina Almasry <almasrymina@...gle.com>, Kuniyuki
 Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, cgroups@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v5 net-next 09/10] net-memcg: Pass struct sock to
 mem_cgroup_sk_under_memory_pressure().

On Fri, 15 Aug 2025 20:16:17 +0000 Kuniyuki Iwashima wrote:
> We will store a flag in the lowest bit of sk->sk_memcg.
> 
> Then, we cannot pass the raw pointer to mem_cgroup_under_socket_pressure().
> 
> Let's pass struct sock to it and rename the function to match other
> functions starting with mem_cgroup_sk_.
> 
> Note that the helper is moved to sock.h to use mem_cgroup_from_sk().
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Roman Gushchin <roman.gushchin@...ux.dev>

Hi Shakeel, looks like you acked every single patch here but this one.
Is this intentional? :)