netdev - Re: [PATCH V2 net 4/8] net/mlx5: Destroy vport QoS element when no configuration remains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6209c4b-c524-41dd-bf67-4dcd67e621fb@intel.com>
Date: Wed, 20 Aug 2025 16:45:43 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Mark Bloch <mbloch@...dia.com>, Carolina Jubran <cjubran@...dia.com>
CC: Tariq Toukan <tariqt@...dia.com>, Leon Romanovsky <leon@...nel.org>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Saeed Mahameed <saeedm@...dia.com>,
	<netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Gal Pressman <gal@...dia.com>, Cosmin Ratiu
	<cratiu@...dia.com>, Mohamad Haj Yahia <mohamad@...lanox.com>, Saeed Mahameed
	<saeedm@...lanox.com>
Subject: Re: [PATCH V2 net 4/8] net/mlx5: Destroy vport QoS element when no
 configuration remains

On 8/20/25 15:32, Mark Bloch wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> If a VF has been configured and the user later clears all QoS settings,
> the vport element remains in the firmware QoS tree. This leads to
> inconsistent behavior compared to VFs that were never configured, since
> the FW assumes that unconfigured VFs are outside the QoS hierarchy.
> As a result, the bandwidth share across VFs may differ, even though
> none of them appear to have any configuration.
> 
> Align the driver behavior with the FW expectation by destroying the
> vport QoS element when all configurations are removed.
> 
> Fixes: c9497c98901c ("net/mlx5: Add support for setting VF min rate")
> Fixes: cf7e73770d1b ("net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw")
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> ---
>   .../net/ethernet/mellanox/mlx5/core/esw/qos.c | 57 ++++++++++++++++---
>   1 file changed, 49 insertions(+), 8 deletions(-)
this is much better, thank you!
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>