netdev - Re: [PATCH net-next 12/15] eth: fbnic: allocate unreadable page pool for the payloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izMEwmcMQ7Z53Z6uV6NJyVQ40ew+CMmCBMHjwYNC3QtdMA@mail.gmail.com>
Date: Wed, 20 Aug 2025 16:33:18 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	michael.chan@...adcom.com, tariqt@...dia.com, dtatulea@...dia.com, 
	hawk@...nel.org, ilias.apalodimas@...aro.org, alexanderduyck@...com, 
	sdf@...ichev.me
Subject: Re: [PATCH net-next 12/15] eth: fbnic: allocate unreadable page pool
 for the payloads

On Tue, Aug 19, 2025 at 7:57 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Allow allocating a page pool with unreadable memory for the payload
> ring (sub1). We need to provide the queue ID so that the memory provider
> can match the PP, and use the appropriate page pool DMA sync helper.
> While at it remove the define for page pool flags.
>
> The rxq_idx is passed to fbnic_alloc_rx_qt_resources() explicitly
> to make it easy to allocate page pools without NAPI (see the patch
> after the next).
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

> +       if (page_pool_rxq_wants_unreadable(&pp_params)) {
> +               pp_params.flags |= PP_FLAG_ALLOW_UNREADABLE_NETMEM;
> +               pp_params.dma_dir = DMA_FROM_DEVICE;
> +

Although I'm not sure why the dma_dir needed to change specifically
for unreadable.

-- 
Thanks,
Mina