netdev - 回覆: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB513431EE31303E834E05704B9D33A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 20 Aug 2025 00:40:02 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Simon Horman <horms@...nel.org>, Heiner
 Kallweit <hkallweit1@...il.com>, Uwe Kleine-König
	<u.kleine-koenig@...libre.com>, Po-Yu Chuang <ratbert@...aday-tech.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject:
 回覆: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100

Hi Andrew,

Thank you for your reply.

> > This patch series adds support for configuring RGMII internal delays
> > for the Aspeed AST2600 FTGMAC100 Ethernet MACs.
> 
> So i think you are doing things in the wrong order. You first need to sort out the
> mess of most, if not all, AST2600 have the wrong phy-mode, because the
> RGMII delay configuration is hidden, and set wrongly.
> 
> Please fix that first.
> 

The RGMII delay is configured in U-boot stage, and it is not changed when booting to
Linux. I want to know whether the first thing to correct here is whether the phy-mode
in aspeed-ast2600-evb.dts is rgmii-id. Our AST2600 EVB, there is no delay on board,
so, I need to change the phy-mode to "rgmii-id" to meet the RGMII usage first?

> Then consider how you can add fine tuning of the delays. Maybe that needs to
> wait for AST2700.

Currently, on AST2700, we use the "rgmii-id" in our SDK/git as per your suggestion.
And we will add the tx/rx-internal-delay-ps properties in the ftgmac100 driver to
support fine tuning of these delays.

Thanks,
Jacky