[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CAP_9mL5U+Xs6T89vT7DGvcmzxMvm8qars4o+5EfzbdU=sqzCXQ@mail.gmail.com>
Date: Thu, 21 Aug 2025 15:39:01 +0800
From: jjm2473 <jjm2473@...il.com>
To: linus.walleij@...aro.org, alsi@...g-olufsen.dk
Cc: netdev@...r.kernel.org
Subject: Maybe a simple bug on rtl8366rb-leds.c
rtl8366rb_led_group_port_mask always use RTL8366RB_LED_0_X_CTRL_MASK
whatever led_group it got:
```
static inline u32 rtl8366rb_led_group_port_mask(u8 led_group, u8 port)
{
switch (led_group) {
case 0:
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
case 1:
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
case 2:
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
case 3:
return FIELD_PREP(RTL8366RB_LED_0_X_CTRL_MASK, BIT(port));
default:
return 0;
}
}
```
Powered by blists - more mailing lists