netdev - Re: [net-next v5 3/3] net: dsa: yt921x: Add support for Motorcomm YT921x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKbZM6oYhIN6cBQb@shell.armlinux.org.uk>
Date: Thu, 21 Aug 2025 09:30:43 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: David Yang <mmyangfl@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Simon Horman <horms@...nel.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next v5 3/3] net: dsa: yt921x: Add support for Motorcomm
 YT921x

On Wed, Aug 20, 2025 at 03:54:16PM +0800, David Yang wrote:
> +static int
> +yt921x_port_config(struct yt921x_priv *priv, int port, unsigned int mode,
> +		   const struct phylink_link_state *state)
> +{
> +	const struct yt921x_info *info = priv->info;
> +	struct device *dev = to_device(priv);
> +	enum yt921x_fixed fixed;
> +	bool duplex_full;
> +	u32 mask;
> +	u32 ctrl;
> +	int res;
> +
> +	if (state->interface != PHY_INTERFACE_MODE_INTERNAL &&
> +	    !yt921x_info_port_is_external(info, port)) {
> +		dev_err(dev, "Wrong mode %d on port %d\n",
> +			state->interface, port);
> +		return -EINVAL;
> +	}
> +
> +	fixed = YT921X_FIXED_NOTFIXED;
> +	ctrl = YT921X_PORT_LINK;
> +	if (mode == MLO_AN_FIXED)
> +		switch (state->speed) {

Someone clearly doesn't believe in reading the documentation before
writing code. This also hasn't been tested in any way. Sorry, but
I'm going to put as much effort into this review as you have into
understanding the phylink API, and thus my review ends here.

NAK.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!