netdev - Re: [PATCHv3 net-next 2/3] bonding: support aggregator selection based on port priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ba2c580-6401-4f95-8d63-48634b834234@redhat.com>
Date: Thu, 21 Aug 2025 11:16:21 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: Jay Vosburgh <jv@...sburgh.net>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
 Jonathan Corbet <corbet@....net>, Petr Machata <petrm@...dia.com>,
 Amit Cohen <amcohen@...dia.com>, Vladimir Oltean <vladimir.oltean@....com>,
 Stephen Hemminger <stephen@...workplumber.org>,
 David Ahern <dsahern@...il.com>, Jonas Gorski <jonas.gorski@...il.com>,
 linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCHv3 net-next 2/3] bonding: support aggregator selection
 based on port priority

On 8/18/25 11:23 AM, Hangbin Liu wrote:
> @@ -1707,6 +1719,9 @@ static struct aggregator *ad_agg_selection_test(struct aggregator *best,
>  	 * BOND_AD_COUNT: Select by count of ports.  If count is equal,
>  	 *     select by bandwidth.
>  	 *
> +	 * BOND_AD_PRIO: Select by total priority of ports. If priority
> +	 *     is equal, select by count.
> +	 *
>  	 * BOND_AD_STABLE, BOND_AD_BANDWIDTH: Select by bandwidth.
>  	 */
>  	if (!best)

Minor nit: I think the comment would be more readable placing
BOND_AD_PRIO before BOND_AD_COUNT, so that each value documentation
references only the following one.

Thanks,

Paolo