netdev - Re: [PATCH net] net: airoha: ppe: Do not invalid PPE entries in case of SW hash collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175576920651.962267.9015249362878728671.git-patchwork-notify@kernel.org>
Date: Thu, 21 Aug 2025 09:40:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, michal.kubiak@...el.com,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] net: airoha: ppe: Do not invalid PPE entries in case
 of SW hash collision

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Mon, 18 Aug 2025 11:58:25 +0200 you wrote:
> SW hash computed by airoha_ppe_foe_get_entry_hash routine (used for
> foe_flow hlist) can theoretically produce collisions between two
> different HW PPE entries.
> In airoha_ppe_foe_insert_entry() if the collision occurs we will mark
> the second PPE entry in the list as stale (setting the hw hash to 0xffff).
> Stale entries are no more updated in airoha_ppe_foe_flow_entry_update
> routine and so they are removed by Netfilter.
> Fix the problem not marking the second entry as stale in
> airoha_ppe_foe_insert_entry routine if we have already inserted the
> brand new entry in the PPE table and let Netfilter remove real stale
> entries according to their timestamp.
> Please note this is just a theoretical issue spotted reviewing the code
> and not faced running the system.
> 
> [...]

Here is the summary with links:
  - [net] net: airoha: ppe: Do not invalid PPE entries in case of SW hash collision
    https://git.kernel.org/netdev/net/c/9f6b606b6b37

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html