netdev - Re: [PATCH net-next v4 6/7] net: devmem: pre-read requested rx queues during bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcj2oerynyc537fekpmvd63ei4ewtajo4ase4y4rp2hghiz4i2@weyhqp4itgez>
Date: Thu, 21 Aug 2025 11:07:18 +0000
From: Dragos Tatulea <dtatulea@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: almasrymina@...gle.com, asml.silence@...il.com, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, cratiu@...dia.com, 
	parav@...dia.com, netdev@...r.kernel.org, sdf@...a.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 6/7] net: devmem: pre-read requested rx
 queues during bind

On Wed, Aug 20, 2025 at 06:09:04PM -0700, Jakub Kicinski wrote:
> On Wed, 20 Aug 2025 20:11:57 +0300 Dragos Tatulea wrote:
> >  	struct nlattr *tb[ARRAY_SIZE(netdev_queue_id_nl_policy)];
> > +	struct nlattr *attr;
> > +	int rem, err = 0;
> > +	u32 rxq_idx;
> > +
> > +	nla_for_each_attr_type(attr, NETDEV_A_DMABUF_QUEUES,
> > +			       genlmsg_data(info->genlhdr),
> > +			       genlmsg_len(info->genlhdr), rem) {
> > +		err = nla_parse_nested(
> > +			tb, ARRAY_SIZE(netdev_queue_id_nl_policy) - 1, attr,
> 
> While you're touching this line, could you perhaps clean up the line
> wrap? Save ARRAY_SIZE(netdev_queue_id_nl_policy) - 1 to a const and
> then:
> 
> 		err = nla_parse_nested(tb, maxtype, attr, 
> 				       netdev_queue_id_nl_policy, info->extack);
> 
> or some such.
Will clean up.

Thanks,
Dragos