netdev - Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250821123134.GD7364@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Thu, 21 Aug 2025 05:31:34 -0700
From: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Ahern <dsahern@...il.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, haiyangz@...rosoft.com,
	shradhagupta@...ux.microsoft.com, ssengar@...rosoft.com,
	dipayanroy@...rosoft.com, ernis@...rosoft.com
Subject: Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to
 'ip link' for netdev shaping

On Mon, Aug 18, 2025 at 09:00:10AM -0700, Jakub Kicinski wrote:
> On Mon, 18 Aug 2025 09:41:29 -0600 David Ahern wrote:
> > On 8/18/25 9:36 AM, Jakub Kicinski wrote:
> > > Somewhat related -- what's your take on integrating / vendoring in YNL?  
> > 
> > I feel like this has been brought up a few times.
> > 
> > Is there a specific proposal or any patches to review?
> 
> Not AFAIK. Erni is being asked to rethink his approach here, and 
> if we're going with a new command perhaps YNL should be on the table.
> 
Thank you for the feedback and for suggesting integration with the ynl
tool.

For the current implementation, I have followed your earlier guidance
( while implementing bandwidth clamping for MANA interface ) and used 
netlink commands similar to those used by ynl to support netshaper
operations from the kernel.

Ref: https://lore.kernel.org/all/20250421170349.003861f2@kernel.org/

> I'd be very interested to get a final ruling on YNL integration 
> into iproute2 -- given its inability to work as a shared object /
> library it's not unreasonable for the answer to be "no". 

This approach, to use netshaper as separate command in iproute2, seemed
like the most practical path forward to address shaping support without
introducing additional complexity.
> 
> The page pool sample in the kernel sources is very useful, I find
> myself copying to various systems during debug. If there's no clear
> path to YNL integration with iproute2 it's time for that sample to
> be come a real CLI tool.