netdev - Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c7ee1e4f-9e1f-43c4-9fc2-0bc92f682aa4@intel.com>
Date: Thu, 21 Aug 2025 08:30:25 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: mohammad heib <mheib@...hat.com>, Simon Horman <horms@...nel.org>
CC: David Hill <dhill@...hat.com>, <netdev@...r.kernel.org>,
	<anthony.l.nguyen@...el.com>, <przemyslaw.kitszel@...el.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit



On 8/21/2025 2:58 AM, mohammad heib wrote:
> Hi
> i defiantly agree with you Jacob
> 
> maybe to avoid removing the params in the future we can implement it 
> this way:
> 
> Instead of a simple boolean parameter, we can introduce a *numeric 
> |max_mac_per_vf| parameter*.
> 
>   *
> 
>     If set to |0|, the driver behaves as legacy (no per-VF limit).
> 
>   *
> 
>     Any non-zero value enforces that maximum number of MACs per VF.
> 
> 
> 
> This design addresses concerns about removing a parameter in the future 
> because:
> 
>   * The parameter can *coexist with a future devlink resource-per-VF
>     implementation*.
>   * if a hierarchy of resources is added later, |max_mac_per_vf = 0|
>     could automatically defer to the resource values, while a non-zero
>     value can act as an override.
>   * This numeric parameter is more flexible than a boolean and easier to
>     extend or adjust at runtime (via devlink in the future).
> 
> I think this is a reasonable *short-term solution* that preserves 
> backward compatibility while allowing for a *long-term devlink 
> resource-based design*.
> 

This seems like a good approach to me.

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)