netdev - Re: [PATCH net-next 03/15] net: phy: aquantia: reorder AQR113C PMD Global Transmit Disable bit clearing with supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0087f090-4ef0-41d5-a3ab-10c1eb2756f4@lunn.ch>
Date: Thu, 21 Aug 2025 18:21:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Daniel Golle <daniel@...rotopia.org>, linux-kernel@...r.kernel.org,
	Nikita Yushchenko <nikita.yoush@...entembedded.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Robert Marko <robimarko@...il.com>,
	Paweł Owoc <frut3k7@...il.com>,
	Sean Anderson <sean.anderson@...o.com>,
	Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH net-next 03/15] net: phy: aquantia: reorder AQR113C PMD
 Global Transmit Disable bit clearing with supported_interfaces

On Thu, Aug 21, 2025 at 06:20:10PM +0300, Vladimir Oltean wrote:
> Introduced in commit bed90b06b681 ("net: phy: aquantia: clear PMD Global
> Transmit Disable bit during init"), the clearing of MDIO_PMA_TXDIS plus
> the call to aqr107_wait_processor_intensive_op() are only by chance
> placed between aqr107_config_init() and aqr107_fill_interface_modes().
> In other words, aqr107_fill_interface_modes() does not depend in any way
> on these 2 operations.
> 
> I am only 90% sure of that, and I intend to move aqr107_fill_interface_modes()
> to be a part of aqr107_config_init() in the future. So to isolate the
> issue for blame attribution purposes, make these 2 functions adjacent to
> each other again.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew