netdev - Re: [PATCH v1 net-next 1/7] tcp: Remove sk_protocol test for tcp_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUCz6DSqDA_-fk=YEW21T_sDTQ0y-0SA6ActmDtOVXU9SQ@mail.gmail.com>
Date: Thu, 21 Aug 2025 10:21:25 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 1/7] tcp: Remove sk_protocol test for tcp_twsk_unique().

On Wed, Aug 20, 2025 at 11:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Wed, Aug 20, 2025 at 11:16 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
> >
> > From: "Kuniyuki Iwashima <kuniyu@...zon.com>
>
> Oh well.
>
> >
> > Commit 383eed2de529 ("tcp: get rid of twsk_unique()") added
> > sk->sk_protocol test in  __inet_check_established() and
> > __inet6_check_established() to remove twsk_unique() and call
> > tcp_twsk_unique() directly.
> >
> > DCCP has gone, and the condition is always true.
> >
> > Let's remove the sk_protocol test.
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
>
> Please fix the From:  because Kuniyuki Iwashima <kuniyu@...zon.com> is
> no longer a valid email address.

Oh sorry, I completely missed that due to mailmap.
WIl fix up the address for patch 1~3.

$ git log
...
commit 2e799f4dc4624c719ca17859c27f7314ff4165d6
Author: Kuniyuki Iwashima <kuniyu@...gle.com>
Date:   Mon Mar 17 04:18:11 2025

    tcp: Remove sk_protocol test for tcp_twsk_unique().

$ git log --no-use-mailmap
...
commit 2e799f4dc4624c719ca17859c27f7314ff4165d6
Author: Kuniyuki Iwashima <kuniyu@...zon.com>
Date:   Mon Mar 17 04:18:11 2025