netdev - Re: [PATCH v5 1/5] net: rnpgbe: Add build support for rnpgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7102c84e-711c-4380-8564-1f1fe65720f0@lunn.ch>
Date: Thu, 21 Aug 2025 05:00:52 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Yibo Dong <dong100@...se.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	corbet@....net, gur.stavi@...wei.com, maddy@...ux.ibm.com,
	mpe@...erman.id.au, danishanwar@...com, lee@...ger.us,
	gongfan1@...wei.com, lorenzo@...nel.org, geert+renesas@...der.be,
	Parthiban.Veerasooran@...rochip.com, lukas.bulwahn@...hat.com,
	alexanderduyck@...com, richardcochran@...il.com,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] net: rnpgbe: Add build support for rnpgbe

> Ok, I will improve it.
> By the way, if I want to add some functions(maybe workqueue to handle
> link status, or debugfs for the driver) in the future. The function is
> only one for driver, not each for every pci device, should I turn back to
> 'module_exit' and 'module_init'?
> Maybe workqueue can use 'system_power_efficient_wq' just like libwx
> does? 

Generally, you don't have per driver data, only per device data. It
makes the locking simpler, and handling bind/unbind etc.

	Andrew