netdev - Re: [PATCH net-next v4 6/7] net: devmem: pre-read requested rx queues during bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250820180904.698f1546@kernel.org>
Date: Wed, 20 Aug 2025 18:09:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: <almasrymina@...gle.com>, <asml.silence@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, <cratiu@...dia.com>,
 <parav@...dia.com>, <netdev@...r.kernel.org>, <sdf@...a.com>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 6/7] net: devmem: pre-read requested rx
 queues during bind

On Wed, 20 Aug 2025 20:11:57 +0300 Dragos Tatulea wrote:
>  	struct nlattr *tb[ARRAY_SIZE(netdev_queue_id_nl_policy)];
> +	struct nlattr *attr;
> +	int rem, err = 0;
> +	u32 rxq_idx;
> +
> +	nla_for_each_attr_type(attr, NETDEV_A_DMABUF_QUEUES,
> +			       genlmsg_data(info->genlhdr),
> +			       genlmsg_len(info->genlhdr), rem) {
> +		err = nla_parse_nested(
> +			tb, ARRAY_SIZE(netdev_queue_id_nl_policy) - 1, attr,

While you're touching this line, could you perhaps clean up the line
wrap? Save ARRAY_SIZE(netdev_queue_id_nl_policy) - 1 to a const and
then:

		err = nla_parse_nested(tb, maxtype, attr, 
				       netdev_queue_id_nl_policy, info->extack);

or some such.