| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250821-silky-slug-of-novelty-e4bb64@kuoka>
Date: Thu, 21 Aug 2025 08:46:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
Cc: airlied@...il.com, amergnat@...libre.com, andrew+netdev@...n.ch,
andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com, broonie@...nel.org,
chunkuang.hu@...nel.org, ck.hu@...iatek.com, conor+dt@...nel.org, davem@...emloft.net,
dmitry.torokhov@...il.com, edumazet@...gle.com, flora.fu@...iatek.com,
houlong.wei@...iatek.com, jeesw@...fas.com, jmassot@...labora.com, kernel@...labora.com,
krzk+dt@...nel.org, kuba@...nel.org, kyrie.wu@...iatek.corp-partner.google.com,
lgirdwood@...il.com, linus.walleij@...aro.org, louisalexis.eyraud@...labora.com,
maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com, mchehab@...nel.org,
minghsiu.tsai@...iatek.com, mripard@...nel.org, p.zabel@...gutronix.de, pabeni@...hat.com,
robh@...nel.org, sean.wang@...nel.org, simona@...ll.ch,
support.opensource@...semi.com, tiffany.lin@...iatek.com, tzimmermann@...e.de,
yunfei.dong@...iatek.com, devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
linux-mediatek@...ts.infradead.org, linux-sound@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp
bindings to YAML
On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote:
> Convert the existing text-based DT bindings for MediaTek MT8173 Media Data Path
> to a YAML schema.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
> ---
> .../bindings/media/mediatek,mt8173-mdp.yaml | 174 ++++++++++++++++++
> .../bindings/media/mediatek-mdp.txt | 95 ----------
> 2 files changed, 174 insertions(+), 95 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8173-mdp.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/mediatek-mdp.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8173-mdp.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8173-mdp.yaml
> new file mode 100644
> index 0000000000000..f3a08afc305b1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8173-mdp.yaml
> @@ -0,0 +1,174 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt8173-mdp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT8173 Media Data Path
> +
> +maintainers:
> + - Ariel D'Alessandro <ariel.dalessandro@...labora.com>
> +
> +description:
> + Media Data Path is used for scaling and color space conversion.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
Just enum, no items here
> + - enum:
> + - mediatek,mt8173-mdp-rdma
> + - mediatek,mt8173-mdp-rsz
> + - mediatek,mt8173-mdp-wdma
> + - mediatek,mt8173-mdp-wrot
> + - items:
> + - enum:
> + - mediatek,mt8173-mdp-rdma
> + - mediatek,mt8173-mdp-rsz
> + - mediatek,mt8173-mdp-wdma
> + - mediatek,mt8173-mdp-wrot
> + - const: mediatek,mt8173-mdp
This makes no sense. How devices can be compatible and can not be
compatible.
> +
> + reg:
> + maxItems: 1
> +
> + clocks: true
No, there's no such syntax. Look at other bindings.
> +
> + power-domains:
> + maxItems: 1
> +
> + iommus:
> + description: |
Drop |
> + This property should point to the respective IOMMU block with master port as argument,
> + see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
Drop entire description, completely redundant. I don't know why my patch
fixing this was not applied, so you keep repeating same mistakes...
> + maxItems: 1
> +
> + mediatek,vpu:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Describes point to vpu.
Useless description. We see that from the property name. Explain the
purpose in the hardware.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - power-domains
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8173-mdp-rdma
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Main clock
> + - description: Mutex clock
> + else:
> + properties:
> + clocks:
> + items:
> + - description: Main clock
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - mediatek,mt8173-mdp-rdma
> + - mediatek,mt8173-mdp-wdma
> + - mediatek,mt8173-mdp-wrot
> + then:
> + required:
> + - iommus
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8173-mdp
This makes no sense either.
> + then:
> + required:
> + - mediatek,vpu
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8173-clk.h>
> + #include <dt-bindings/memory/mt8173-larb-port.h>
> + #include <dt-bindings/power/mt8173-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + mdp_rdma0: rdma@...01000 {
One example is enough. Two could be fine if they differ significantly.
Best regards,
Krzysztof
Powered by blists - more mailing lists