netdev - RE: [PATCH v2 net-next 1/5] net: fec: use a member variable for maximum buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85109F9421FCC1381407232B883DA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 22 Aug 2025 08:01:31 +0000
From: Wei Fang <wei.fang@....com>
To: Shenwei Wang <shenwei.wang@....com>
CC: Clark Wang <xiaoning.wang@....com>, Stanislav Fomichev <sdf@...ichev.me>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>, Andrew Lunn
	<andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov
	<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard
 Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>
Subject: RE: [PATCH v2 net-next 1/5] net: fec: use a member variable for
 maximum buffer size

>  	struct fec_enet_private *fep = netdev_priv(ndev);
> -	u32 rcntl = OPT_FRAME_SIZE | FEC_RCR_MII;
> +	u32 rcntl = FEC_RCR_MII;

nit: move this line under 'u32 ecntl = FEC_ECR_ETHEREN;'
see https://elixir.bootlin.com/linux/v6.17-rc2/source/Documentation/process/maintainer-netdev.rst#L368

>  	u32 ecntl = FEC_ECR_ETHEREN;
> 
> +	if (fep->max_buf_size == OPT_FRAME_SIZE)

fep->max_buf_size = PKT_MAXBUF_SIZE;
#define	OPT_FRAME_SIZE	(PKT_MAXBUF_SIZE << 16)

So fep->max_buf_size will never be equal to OPT_FRAME_SIZE,
so always take the false branch.

> +		rcntl |= (fep->max_buf_size << 16);

nit: the parentheses are unnecessary