netdev - Re: [PATCH net-next 2/2] dt-bindings: net: mxl: Add MxL LGM Network Processor SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c941b600-ec7d-4167-8f7b-7ea761017603@kernel.org>
Date: Fri, 22 Aug 2025 11:39:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jack Ping CHNG <jchng@...linear.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, yzhu@...linear.com, sureshnagaraj@...linear.com
Subject: Re: [PATCH net-next 2/2] dt-bindings: net: mxl: Add MxL LGM Network
 Processor SoC

On 22/08/2025 11:08, Jack Ping CHNG wrote:
> Introduce device-tree binding documentation for
> MaxLinear LGM Network Processor

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Bindings go before the user (see submitting bindings in DT dir).

> 
> Signed-off-by: Jack Ping CHNG <jchng@...linear.com>
> ---
>  .../devicetree/bindings/net/mxl,lgm-eth.yaml  | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml b/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> new file mode 100644
> index 000000000000..3d5b32b5b650
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/net/mxl,lgm-eth.yaml#"

You never tested it, did you?

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Nope. Please point me to any example if such syntax.

I will finish the review here. I am sorry, but I think you really did
not put enough of effort into this. There are so many basic mistakes
here. Please watch my OSSE session explaining basics of bindings (or
read the slides - they are already published).


Best regards,
Krzysztof