netdev - Re: [PATCH net-next v2 3/4] rds: Fix endianness annotation for RDS_MPATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35c7c1aad491504a4da79aee079ce7a4743a5778.camel@oracle.com>
Date: Fri, 22 Aug 2025 00:56:24 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "horms@...nel.org" <horms@...nel.org>,
        "ujwal.kundur@...il.com"
	<ujwal.kundur@...il.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 3/4] rds: Fix endianness annotation for
 RDS_MPATH_HASH

On Wed, 2025-08-20 at 23:25 +0530, Ujwal Kundur wrote:
> jhash_1word accepts host endian inputs while rs_bound_port is a be16
> value (sockaddr_in6.sin6_port). Use ntohs() for consistency.
> 
> Flagged by Sparse.
> 
> Signed-off-by: Ujwal Kundur <ujwal.kundur@...il.com>
This looks fine.  Thank you!
Reviewed-by: Allison Henderson <allison.henderson@...cle.com>

> ---
>  net/rds/rds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/rds/rds.h b/net/rds/rds.h
> index dc360252c515..5b1c072e2e7f 100644
> --- a/net/rds/rds.h
> +++ b/net/rds/rds.h
> @@ -93,7 +93,7 @@ enum {
>  
>  /* Max number of multipaths per RDS connection. Must be a power of 2 */
>  #define	RDS_MPATH_WORKERS	8
> -#define	RDS_MPATH_HASH(rs, n) (jhash_1word((rs)->rs_bound_port, \
> +#define	RDS_MPATH_HASH(rs, n) (jhash_1word(ntohs((rs)->rs_bound_port), \
>  			       (rs)->rs_hash_initval) & ((n) - 1))
>  
>  #define IS_CANONICAL(laddr, faddr) (htonl(laddr) < htonl(faddr))