netdev - Re: [PATCH] netfilter: conntrack: drop expectations before freeing templates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250822011756.3264808-1-xqjcool@gmail.com>
Date: Thu, 21 Aug 2025 18:17:56 -0700
From: Qingjie Xing <xqjcool@...il.com>
To: fw@...len.de
Cc: linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org,
	xqjcool@...il.com
Subject: Re: [PATCH] netfilter: conntrack: drop expectations before freeing templates

Thanks for the careful review and the pointers.

I dug deeper and found the root cause on my side: there was leftover/out-of-tree
 code in my local tree that could attach the per-rule template to skb->_nfct. 
After cleaning up those remnants, upstream behavior matches your description—
nf_conntrack_in() clears any template, tftp_help() sees a real conntrack, 
and I can no longer reproduce the crash.

Apologies for the noise and for any time this cost you. I’ll withdraw the patch 
as it was addressing a problem introduced by my local changes. 

Thanks again for the guidance.