netdev - Re: [PATCH net-next 2/3] net: airoha: Add airoha_ppe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250821183453.4136c5d3@kernel.org>
Date: Thu, 21 Aug 2025 18:34:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] net: airoha: Add airoha_ppe_dev struct
 definition

On Tue, 19 Aug 2025 14:21:07 +0200 Lorenzo Bianconi wrote:
> +	pdev = of_find_device_by_node(np);
> +

did you mean to put the of_node_put() here?

> +	if (!pdev) {
> +		dev_err(dev, "cannot find device node %s\n", np->name);
> +		of_node_put(np);
> +		return ERR_PTR(-ENODEV);
> +	}
> +	of_node_put(np);
> +
> +	if (!try_module_get(THIS_MODULE)) {
> +		dev_err(dev, "failed to get the device driver module\n");
> +		goto error_pdev_put;
> +	}