netdev - Re: [PATCH net-next 3/4] selftests: drv-net: ncdevmem: restore old channel config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKjrwJsQP1AUACYH@mini-arch>
Date: Fri, 22 Aug 2025 15:14:24 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	almasrymina@...gle.com, sdf@...ichev.me, joe@...a.to,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] selftests: drv-net: ncdevmem: restore old
 channel config

On 08/22, Jakub Kicinski wrote:
> In case changing channel count with provider bound succeeds
> unexpectedly - make sure we return to original settings.

Acked-by: Stanislav Fomichev <sdf@...ichev.me>

> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  .../selftests/drivers/net/hw/ncdevmem.c       | 34 ++++++++++++-------
>  1 file changed, 22 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> index 8d9d579834b1..580b4459a840 100644
> --- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> +++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
> @@ -469,7 +469,7 @@ static void reset_rss(void)
>  	run_command("ethtool -X %s default >&2", ifname, start_queue);
>  }
>  
> -static int configure_channels(unsigned int rx, unsigned int tx)
> +static int check_changing_channels(unsigned int rx, unsigned int tx)

Good call on renaming!