netdev - Re: [PATCH net-next 4/4] selftests: drv-net: ncdevmem: configure and restore HDS threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250822153429.4e6829b4@kernel.org>
Date: Fri, 22 Aug 2025 15:34:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 almasrymina@...gle.com, sdf@...ichev.me, joe@...a.to,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] selftests: drv-net: ncdevmem: configure
 and restore HDS threshold

On Fri, 22 Aug 2025 15:26:37 -0700 Stanislav Fomichev wrote:
> > @@ -436,8 +490,14 @@ static int configure_headersplit(bool on)
> >  
> >  	req = ethtool_rings_set_req_alloc();
> >  	ethtool_rings_set_req_set_header_dev_index(req, ifindex);
> > -	/* 0 - off, 1 - auto, 2 - on */
> > -	ethtool_rings_set_req_set_tcp_data_split(req, on ? 2 : 0);
> > +	if (on) {
> > +		ethtool_rings_set_req_set_tcp_data_split(req,
> > +						ETHTOOL_TCP_DATA_SPLIT_ENABLED);
> > +		ethtool_rings_set_req_set_hds_thresh(req, 0);  
> 
> From talking to Taehee awhile ago it seemed like unconditionally
> setting 0 will fail on the devices that don't support it.
> Is it not the case anymore with ethnl_set_rings_validate?

Good point! ring params are validated against the supported attr flags.
We can pass in config here and only set hds_thresh if max was reported.
That should mean driver supports the setting.