netdev - Re: [PATCH net-next v4 7/7] net: dsa: lantiq_gswip: store switch API version in priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c05a103-5e7c-4ad7-a648-4b7d573ca09b@lunn.ch>
Date: Sun, 24 Aug 2025 18:00:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Andreas Schirm <andreas.schirm@...mens.com>,
	Lukas Stockmann <lukas.stockmann@...mens.com>,
	Alexander Sverdlin <alexander.sverdlin@...mens.com>,
	Peter Christen <peter.christen@...mens.com>,
	Avinash Jayaraman <ajayaraman@...linear.com>,
	Bing tao Xu <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
	Juraj Povazanec <jpovazanec@...linear.com>,
	"Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
	"Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
	"Livia M. Rosu" <lrosu@...linear.com>,
	John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v4 7/7] net: dsa: lantiq_gswip: store switch API
 version in priv

On Fri, Aug 22, 2025 at 05:12:21PM +0100, Daniel Golle wrote:
> Store the switch API version in struct gswip_priv. As the hardware has
> the 'major/minor' version bytes in the wrong order preventing numerical
> comparisons the version to be stored in gswip_priv is constructed in
> such a way that the REV field is the most significant byte and the MOD
> field the least significant byte. Also provide a conveniance macro to
> allow comparing the stored version of the hardware against the already
> defined GSWIP_VERSION_* macros.
>
> This is done in order to prepare supporting newer features such as 4096
> VLANs and per-port configurable learning which are only available
> starting from specific hardware versions.

Thanks for the updated commit message and comments. This is much
clearer and the code avoids all the issues around endianness.

> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew