netdev - Re: [PATCH v2 net-next 5/6] tcp: Don't pass hashinfo to inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL_D6p0CwvBpPVWvQu0m6vN4Trgum40-F6txjOwz9T1cw@mail.gmail.com>
Date: Mon, 25 Aug 2025 07:00:03 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 5/6] tcp: Don't pass hashinfo to inet_diag helpers.

On Fri, Aug 22, 2025 at 12:08 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> These inet_diag functions required struct inet_hashinfo because
> they are shared by TCP and DCCP:
>
>   * inet_diag_dump_icsk()
>   * inet_diag_dump_one_icsk()
>   * inet_diag_find_one_icsk()
>
> DCCP has gone, and we don't need to pass hashinfo down to them.
>
> Let's fetch net->ipv4.tcp_death_row.hashinfo directly in the first
> 2 functions.
>
> Note that inet_diag_find_one_icsk() don't need hashinfo since the
> previous patch.
>
> We will move TCP-specific functions to tcp_diag.c in the next patch.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>