netdev - Re: [PATCH net] sfc: remove ASSERT_RTNL() from get_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <338a2540-d64c-4d5c-9fa9-fc53e607252d@lunn.ch>
Date: Mon, 25 Aug 2025 18:25:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: mheib@...hat.com
Cc: netdev@...r.kernel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net] sfc: remove ASSERT_RTNL() from get_ts_info function

On Mon, Aug 25, 2025 at 04:57:49PM +0300, mheib@...hat.com wrote:
> From: Mohammad Heib <mheib@...hat.com>
> 
> The SFC driver currently asserts that the RTNL lock is held in
> efx_ptp_get_ts_info() using ASSERT_RTNL(). While this is correct for
> the ethtool ioctl path, this function can also be called from the
> SO_TIMESTAMPING socket path where RTNL is not held, which triggers
> kernel BUGs in debug builds.
> 
> This patch removes the ASSERT_RTNL() to avoid these assertions in
> kernel logs when called from paths that do not hold RTNL.

What is missing from the commit message is an explanation of why RTNL
does not need to be held in this function. Maybe this is a real bug
and you are just hiding it, rather than fixing it?

    Andrew