netdev - Re: [PATCH net v1] Fixes: xircom auto-negoation timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+hkOd72gg-8VVfdpNpATbunJt-Oc7Dujor9crQP7sFiDj_L8w@mail.gmail.com>
Date: Mon, 25 Aug 2025 10:40:45 -0700
From: Alex Tran <alex.t.tran@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v1] Fixes: xircom auto-negoation timer

> > You state this is a fix. Which problem does it fix?
The change was originally suggested under a FIXME comment but it seems
like more of a cleanup.

> > Do you have this hardware for testing your patches?
I do not have the physical hardware. The change was made based on code
analysis and successful kselftests and kernel compilation on all yes
config.

> > You might consider migrating this driver to use phylib.
> > Provided this contributes to reducing complexity.
>
> There is plenty to reduce. There is a full bit-banging MDIO
> implementation which could be replaced with the core implementation.
>
> The harder part for converting to phylib will be the ML6692 and
> DP83840A. There are no Linux driver for these, but given the age,
> there is a good chance genphy will work.

Migrating the driver to use phylib sounds like a good idea. I can
rework this patch and send in a v2 with the changes if you all are
fine with moving forward with this.



-- 
Alex Tran