netdev - Re: [PATCH net-next 5/6] net: dsa: lantiq_gswip: support standard MDIO node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c627bfef02dfd670ef1c07267f53468ca1c3df72.camel@siemens.com>
Date: Tue, 26 Aug 2025 07:23:23 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "hauke@...ke-m.de" <hauke@...ke-m.de>, "olteanv@...il.com"
	<olteanv@...il.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"andrew@...n.ch" <andrew@...n.ch>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "daniel@...rotopia.org"
	<daniel@...rotopia.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "john@...ozen.org" <john@...ozen.org>, "Stockmann, Lukas"
	<lukas.stockmann@...mens.com>, "yweng@...linear.com" <yweng@...linear.com>,
	"fchan@...linear.com" <fchan@...linear.com>, "lxu@...linear.com"
	<lxu@...linear.com>, "jpovazanec@...linear.com" <jpovazanec@...linear.com>,
	"Schirm, Andreas" <andreas.schirm@...mens.com>, "Christen, Peter"
	<peter.christen@...mens.com>, "ajayaraman@...linear.com"
	<ajayaraman@...linear.com>, "bxu@...linear.com" <bxu@...linear.com>,
	"lrosu@...linear.com" <lrosu@...linear.com>
Subject: Re: [PATCH net-next 5/6] net: dsa: lantiq_gswip: support standard
 MDIO node name

Hi!

On Tue, 2025-08-26 at 01:14 +0100, Daniel Golle wrote:
> Instead of matching against the child node's compatible string also
> support locating the node of the device tree node of the MDIO bus
> in the standard way by referencing the node name ("mdio").
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

> ---
>  drivers/net/dsa/lantiq_gswip.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index f9b03fb5f57b..23b68047f3c4 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -286,6 +286,9 @@ static int gswip_mdio(struct gswip_priv *priv)
>  	int err = 0;
>  
>  	mdio_np = of_get_compatible_child(switch_np, "lantiq,xrx200-mdio");
> +	if (!mdio_np)
> +		mdio_np = of_get_child_by_name(switch_np, "mdio");
> +
>  	if (!of_device_is_available(mdio_np))
>  		goto out_put_node;

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com