netdev - Re: [PATCH net-next] net: stmmac: rk: remove incorrect _DLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK2M2j7-CpnydtUh@shell.armlinux.org.uk>
Date: Tue, 26 Aug 2025 11:30:50 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: david.wu@...k-chips.com, jonas@...boo.se, mcoquelin.stm32@...il.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next] net: stmmac: rk: remove incorrect _DLY_DISABLE
 bit definition

On Tue, Aug 26, 2025 at 03:22:15AM -0700, Alok Tiwari wrote:
> The RK3328 GMAC clock delay macros define enable/disable controls for
> TX and RX clock delay. While the TX definitions are correct, the
> RXCLK_DLY_DISABLE macro incorrectly clears bit 0.
> 
> The macros RK3328_GMAC_TXCLK_DLY_DISABLE and
> RK3328_GMAC_RXCLK_DLY_DISABLE are not referenced anywhere
> in the driver code. Remove them to clean up unused definitions.
> 
> No functional change.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Looks correct to me!

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!