netdev - Re: [PATCH iwl-next v2 00/15] Fwlog support in ixgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250826134851.GA5892@horms.kernel.org>
Date: Tue, 26 Aug 2025 14:48:51 +0100
From: Simon Horman <horms@...nel.org>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	przemyslaw.kitszel@...el.com, dawid.osuchowski@...ux.intel.com
Subject: Re: [PATCH iwl-next v2 00/15] Fwlog support in ixgbe

On Tue, Aug 12, 2025 at 06:23:21AM +0200, Michal Swiatkowski wrote:
> Hi,
> 
> Firmware logging is a feature that allow user to dump firmware log using
> debugfs interface. It is supported on device that can handle specific
> firmware ops. It is true for ice and ixgbe driver.
> 
> Prepare code from ice driver to be moved to the library code and reuse
> it in ixgbe driver.
> 
> v1 --> v2: [1]
>  * fix building issue in patch 9
> 
> [1] https://lore.kernel.org/netdev/20250722104600.10141-1-michal.swiatkowski@linux.intel.com/
> 
> Michal Swiatkowski (15):
>   ice: make fwlog functions static
>   ice: move get_fwlog_data() to fwlog file
>   ice: drop ice_pf_fwlog_update_module()
>   ice: introduce ice_fwlog structure
>   ice: add pdev into fwlog structure and use it for logging
>   ice: allow calling custom send function in fwlog
>   ice: move out debugfs init from fwlog
>   ice: check for PF number outside the fwlog code

nit: I think that patch 8/15 updates ice_fwlog_init()
     such that it begins with a blank line. I would delete it.

>   ice: drop driver specific structure from fwlog code
>   libie, ice: move fwlog admin queue to libie
>   ice: move debugfs code to fwlog
>   ice: prepare for moving file to libie
>   ice: reregister fwlog after driver reinit
>   ice, libie: move fwlog code to libie
>   ixgbe: fwlog support for e610

...

The nit above notwithstanding, this looks good to me.
Please feel free to add:

Reviewed-by: Simon Horman <horms@...nel.org>