netdev - Re: [PATCH net-next v01 04/12] hinic3: HW capability initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66f3bae8-a386-4205-97b2-7c75bc2ac378@linux.dev>
Date: Tue, 26 Aug 2025 15:17:28 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 linux-doc@...r.kernel.org, Jonathan Corbet <corbet@....net>,
 Bjorn Helgaas <helgaas@...nel.org>, luosifu <luosifu@...wei.com>,
 Xin Guo <guoxin09@...wei.com>, Shen Chenyang <shenchenyang1@...ilicon.com>,
 Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
 Shi Jing <shijing34@...wei.com>, Meny Yossefi <meny.yossefi@...wei.com>,
 Gur Stavi <gur.stavi@...wei.com>, Lee Trager <lee@...ger.us>,
 Michael Ellerman <mpe@...erman.id.au>, Suman Ghosh <sumang@...vell.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Joe Damato <jdamato@...tly.com>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next v01 04/12] hinic3: HW capability initialization

On 26/08/2025 10:05, Fan Gong wrote:
> Use mailbox to get device capability for initializing driver capability.
> 
> Co-developed-by: Xin Guo <guoxin09@...wei.com>
> Signed-off-by: Xin Guo <guoxin09@...wei.com>
> Co-developed-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Zhu Yikai <zhuyikai1@...artners.com>
> Signed-off-by: Fan Gong <gongfan1@...wei.com>
> ---
>   .../ethernet/huawei/hinic3/hinic3_hw_cfg.c    | 66 +++++++++++++++++++
>   .../ethernet/huawei/hinic3/hinic3_hw_cfg.h    |  1 +
>   .../ethernet/huawei/hinic3/hinic3_hw_intf.h   | 42 ++++++++++++
>   .../net/ethernet/huawei/hinic3/hinic3_hwdev.c |  6 ++
>   4 files changed, 115 insertions(+)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c b/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c
> index e7ef450c4971..24b929690f64 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c
> @@ -8,6 +8,67 @@
>   #include "hinic3_hwif.h"
>   #include "hinic3_mbox.h"
>   
> +#define HINIC3_CFG_MAX_QP  256
> +
> +static void parse_pub_res_cap(struct hinic3_hwdev *hwdev,
> +			      struct hinic3_dev_cap *cap,
> +			      const struct cfg_cmd_dev_cap *dev_cap,
> +			      enum hinic3_func_type type)
> +{
> +	cap->port_id = dev_cap->port_id;
> +	cap->supp_svcs_bitmap = dev_cap->svc_cap_en;
> +}
> +
> +static void parse_l2nic_res_cap(struct hinic3_hwdev *hwdev,
> +				struct hinic3_dev_cap *cap,
> +				const struct cfg_cmd_dev_cap *dev_cap,
> +				enum hinic3_func_type type)
> +{
> +	struct hinic3_nic_service_cap *nic_svc_cap = &cap->nic_svc_cap;
> +
> +	nic_svc_cap->max_sqs = min(dev_cap->nic_max_sq_id + 1,
> +				   HINIC3_CFG_MAX_QP);
> +}
> +
> +static void parse_dev_cap(struct hinic3_hwdev *hwdev,
> +			  const struct cfg_cmd_dev_cap *dev_cap,
> +			  enum hinic3_func_type type)
> +{
> +	struct hinic3_dev_cap *cap = &hwdev->cfg_mgmt->cap;
> +
> +	/* Public resource */
> +	parse_pub_res_cap(hwdev, cap, dev_cap, type);
> +
> +	/* L2 NIC resource */
> +	if (hinic3_support_nic(hwdev))
> +		parse_l2nic_res_cap(hwdev, cap, dev_cap, type);
> +}

Could you please prepend local functions with the scope (hinic3) to be
consistent with naming? Some of functions have pretty common name and
may potentially overlap with some core functions.

> +
> +static int get_cap_from_fw(struct hinic3_hwdev *hwdev,
> +			   enum hinic3_func_type type)
> +{
> +	struct mgmt_msg_params msg_params = {};
> +	struct cfg_cmd_dev_cap dev_cap = {};
> +	int err;
> +
> +	dev_cap.func_id = hinic3_global_func_id(hwdev);
> +
> +	mgmt_msg_params_init_default(&msg_params, &dev_cap, sizeof(dev_cap));
> +
> +	err = hinic3_send_mbox_to_mgmt(hwdev, MGMT_MOD_CFGM,
> +				       CFG_CMD_GET_DEV_CAP, &msg_params);
> +	if (err || dev_cap.head.status) {
> +		dev_err(hwdev->dev,
> +			"Failed to get capability from FW, err: %d, status: 0x%x\n",
> +			err, dev_cap.head.status);
> +		return -EIO;
> +	}
> +
> +	parse_dev_cap(hwdev, &dev_cap, type);
> +
> +	return 0;
> +}
> +
>   static int hinic3_init_irq_info(struct hinic3_hwdev *hwdev)
>   {
>   	struct hinic3_cfg_mgmt_info *cfg_mgmt = hwdev->cfg_mgmt;
> @@ -180,6 +241,11 @@ void hinic3_free_irq(struct hinic3_hwdev *hwdev, u32 irq_id)
>   	mutex_unlock(&irq_info->irq_mutex);
>   }
>   
> +int init_capability(struct hinic3_hwdev *hwdev)
> +{
> +	return get_cap_from_fw(hwdev, HINIC3_FUNC_TYPE_VF);
> +}
> +
>   bool hinic3_support_nic(struct hinic3_hwdev *hwdev)
>   {
>   	return hwdev->cfg_mgmt->cap.supp_svcs_bitmap &
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h b/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h
> index 5978cbd56fb2..8900b40e3c42 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.h
> @@ -49,6 +49,7 @@ int hinic3_alloc_irqs(struct hinic3_hwdev *hwdev, u16 num,
>   		      struct msix_entry *alloc_arr, u16 *act_num);
>   void hinic3_free_irq(struct hinic3_hwdev *hwdev, u32 irq_id);
>   
> +int init_capability(struct hinic3_hwdev *hwdev);

and especially non-static functions has to be prefixed with the
scope, please

>   bool hinic3_support_nic(struct hinic3_hwdev *hwdev);
>   u16 hinic3_func_max_qnum(struct hinic3_hwdev *hwdev);
>   u8 hinic3_physical_port_id(struct hinic3_hwdev *hwdev);

[...]