netdev - Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d15313f4-46d1-4096-bdf1-783afd8e439d@amperemail.onmicrosoft.com>
Date: Tue, 26 Aug 2025 16:51:05 -0400
From: Adam Young <admiyo@...eremail.onmicrosoft.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, admiyo@...amperecomputing.com,
 Matt Johnston <matt@...econstruct.com.au>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Sudeep Holla <sudeep.holla@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC
 Transport

In addition to the below comment, I am removing the additional lock on 
the skb lists and using the internal one for all operations.  It leads 
to leaner and cleaner code.

Updated driver shortly.

On 8/22/25 04:21, Jeremy Kerr wrote:
>> +       mctp_pcc_ndev->inbox.chan->rx_alloc = mctp_pcc_rx_alloc;
>> +       mctp_pcc_ndev->outbox.chan->manage_writes = true;
>> +
>> +       /* There is no clean way to pass the MTU to the callback function
>> +        * used for registration, so set the values ahead of time.
>> +        */
> For my own clarity, what's "the callback function used for
> registration"?

Actually, this is not longer true: we can do it in ndo_open, and it is 
clean.  Removed the comment.